Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAT-7852: set activeOnly argument to false when expansion type is Latest #107

Merged
merged 2 commits into from
Nov 25, 2024
Merged

MAT-7852: set activeOnly argument to false when expansion type is Latest #107

merged 2 commits into from
Nov 25, 2024

Conversation

etan-sb
Copy link
Contributor

@etan-sb etan-sb commented Nov 19, 2024

Terminology Service PR

Jira Ticket: MAT-7852
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@etan-sb etan-sb requested a review from a team as a code owner November 19, 2024 23:09
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.02%. Comparing base (974405b) to head (e516797).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #107      +/-   ##
=============================================
+ Coverage      71.96%   72.02%   +0.05%     
  Complexity       189      189              
=============================================
  Files             19       19              
  Lines            988      990       +2     
  Branches          84       84              
=============================================
+ Hits             711      713       +2     
  Misses           234      234              
  Partials          43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@etan-sb etan-sb merged commit 41855fa into develop Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotanchik-SB jkotanchik-SB jkotanchik-SB approved these changes

@adongare adongare adongare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etan-sb @adongare @jkotanchik-SB